Repository navigation
Test: Count a TSan report only when the racing access is in the extension - #230
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first-report output added in #221 showed what failed on Linux CI: two
PyUnicode_FromStringmemcpys in libpython, writing into memory that the uninstrumented allocator had handed from one finished thread to another. TSan cannot see that synchronisation. Ourtp_wrap_usekonly appeared further up as the caller. The old filter counted any report with an extension frame anywhere in it.Now a report counts only when the access itself was made by the extension: the first frame of either racing access outside the sanitizer runtime must be in
ftmod.Verification:
tp_*accesses inftmodis counted.test_threadsanitizer_sees_a_plain_epoch, so a planted race in the header is still caught.